Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added value checks for "rect" and "roundrect" #62

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Added value checks for "rect" and "roundrect" #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b0c84a
Error codes for unexpected inputs
Ashtreighlia Aug 20, 2023
905633e
Added one more check for roundrect
Ashtreighlia Aug 20, 2023
d6262b4
adopted some of the phrasing
Ashtreighlia Aug 20, 2023
75c1978
code format
FoamyGuy Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions adafruit_display_shapes/rect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ def __init__(
outline: Optional[int] = None,
stroke: int = 1,
) -> None:
if width <= 0 or height <= 0:
raise ValueError("Rectangle dimensions must be larger than 0.")

self._bitmap = displayio.Bitmap(width, height, 2)
self._palette = displayio.Palette(2)

Expand Down
7 changes: 7 additions & 0 deletions adafruit_display_shapes/roundrect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ def __init__(
outline: Optional[int] = None,
stroke: int = 1,
) -> None:
if width <= 0 or height <= 0:
raise ValueError("Rectangle dimensions must be larger than 0.")
if r > width / 2 or r > height / 2:
raise ValueError(
"Radius cannot exceed half of the smaller side (width or height)."
)

self._palette = displayio.Palette(3)
self._palette.make_transparent(0)
self._bitmap = displayio.Bitmap(width, height, 3)
Expand Down