Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer sidenav style #45

Merged
merged 4 commits into from
Mar 16, 2017
Merged

Conversation

plastikaweb
Copy link
Contributor

-feat(sidenav/footer/styling): sidenav layout open/close state; footer mobile buttons
-style(styling): fix some styles issues raised after covalent package updating
-style(covalent): color palette apply
-fix(covalent): hack to prevent vertical scroll on input search component: covalent issue: Teradata/covalent#412

@plastikaweb plastikaweb force-pushed the footer-sidenav-style branch from 3714358 to bab6e2e Compare March 16, 2017 14:48
.gitignore Outdated
@@ -48,3 +48,7 @@ Thumbs.db
# DB data
/db/data/*
!/db/data/*.sample

# Javascript files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you added this block? Which js files are to be ignored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated files from typescript source files. For example webstorm with some configurations could expose them. I think would be better as a preventive measure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just change /scripts/*.js for /db/**/*.js.

@plastikaweb plastikaweb force-pushed the footer-sidenav-style branch from bab6e2e to 9dfb489 Compare March 16, 2017 15:45
@zuzust zuzust self-assigned this Mar 16, 2017
@zuzust zuzust added this to the Iteration #1 milestone Mar 16, 2017
@zuzust zuzust merged commit 9dfb489 into adab1ts:master Mar 16, 2017
@plastikaweb plastikaweb deleted the footer-sidenav-style branch March 16, 2017 16:53
@plastikaweb plastikaweb removed this from the Iteration #1 milestone Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants