-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C17 - Celina #121
base: master
Are you sure you want to change the base?
C17 - Celina #121
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,5 +5,5 @@ pluggy==0.13.1 | |
pprintpp==0.4.0 | ||
py==1.10.0 | ||
pyparsing==2.4.7 | ||
pytest==6.2.1 | ||
pytest==6.2.5 | ||
toml==0.10.2 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
from viewing_party.party import * | ||
from tests.test_constants import * | ||
|
||
@pytest.mark.skip() | ||
#@pytest.mark.skip() | ||
def test_create_successful_movie(): | ||
# Arrange | ||
movie_title = MOVIE_TITLE_1 | ||
|
@@ -15,11 +15,11 @@ def test_create_successful_movie(): | |
new_movie = create_movie(movie_title, genre, rating) | ||
|
||
# Assert | ||
assert new_movie["title"] is MOVIE_TITLE_1 | ||
assert new_movie["genre"] is GENRE_1 | ||
assert new_movie["title"] == MOVIE_TITLE_1 | ||
assert new_movie["genre"] == GENRE_1 | ||
assert new_movie["rating"] == pytest.approx(RATING_1) | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_create_no_title_movie(): | ||
# Arrange | ||
movie_title = None | ||
|
@@ -32,7 +32,7 @@ def test_create_no_title_movie(): | |
# Assert | ||
assert new_movie is None | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_create_no_genre_movie(): | ||
# Arrange | ||
movie_title = "Title A" | ||
|
@@ -45,7 +45,7 @@ def test_create_no_genre_movie(): | |
# Assert | ||
assert new_movie is None | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_create_no_rating_movie(): | ||
# Arrange | ||
movie_title = "Title A" | ||
|
@@ -58,7 +58,7 @@ def test_create_no_rating_movie(): | |
# Assert | ||
assert new_movie is None | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_adds_movie_to_user_watched(): | ||
# Arrange | ||
movie = { | ||
|
@@ -74,12 +74,12 @@ def test_adds_movie_to_user_watched(): | |
updated_data = add_to_watched(user_data, movie) | ||
|
||
# Assert | ||
assert len(updated_data["watched"]) is 1 | ||
assert updated_data["watched"][0]["title"] is MOVIE_TITLE_1 | ||
assert updated_data["watched"][0]["genre"] is GENRE_1 | ||
assert updated_data["watched"][0]["rating"] is RATING_1 | ||
assert len(updated_data["watched"]) == 1 | ||
assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1 | ||
assert updated_data["watched"][0]["genre"] == GENRE_1 | ||
assert updated_data["watched"][0]["rating"] == RATING_1 | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_adds_movie_to_user_watchlist(): | ||
# Arrange | ||
movie = { | ||
|
@@ -95,12 +95,12 @@ def test_adds_movie_to_user_watchlist(): | |
updated_data = add_to_watchlist(user_data, movie) | ||
|
||
# Assert | ||
assert len(updated_data["watchlist"]) is 1 | ||
assert updated_data["watchlist"][0]["title"] is MOVIE_TITLE_1 | ||
assert updated_data["watchlist"][0]["genre"] is GENRE_1 | ||
assert updated_data["watchlist"][0]["rating"] is RATING_1 | ||
assert len(updated_data["watchlist"]) == 1 | ||
assert updated_data["watchlist"][0]["title"] == MOVIE_TITLE_1 | ||
assert updated_data["watchlist"][0]["genre"] == GENRE_1 | ||
assert updated_data["watchlist"][0]["rating"] == RATING_1 | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_moves_movie_from_watchlist_to_empty_watched(): | ||
# Arrange | ||
janes_data = { | ||
|
@@ -116,14 +116,14 @@ def test_moves_movie_from_watchlist_to_empty_watched(): | |
updated_data = watch_movie(janes_data, MOVIE_TITLE_1) | ||
|
||
# Assert | ||
assert len(updated_data["watchlist"]) is 0 | ||
assert len(updated_data["watched"]) is 1 | ||
|
||
assert len(updated_data["watchlist"]) == 0 | ||
assert len(updated_data["watched"]) == 1 | ||
assert updated_data["watched"][0]["title"] == MOVIE_TITLE_1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
# ******************************************************************************************* | ||
# ****** Add assertions here to test that the correct movie was added to "watched" ********** | ||
# ******************************************************************************************* | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_moves_movie_from_watchlist_to_watched(): | ||
# Arrange | ||
movie_to_watch = HORROR_1 | ||
|
@@ -139,14 +139,14 @@ def test_moves_movie_from_watchlist_to_watched(): | |
updated_data = watch_movie(janes_data, movie_to_watch["title"]) | ||
|
||
# Assert | ||
assert len(updated_data["watchlist"]) is 1 | ||
assert len(updated_data["watched"]) is 2 | ||
|
||
assert len(updated_data["watchlist"]) == 1 | ||
assert len(updated_data["watched"]) == 2 | ||
assert movie_to_watch in updated_data["watched"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
# ******************************************************************************************* | ||
# ****** Add assertions here to test that the correct movie was added to "watched" ********** | ||
# ******************************************************************************************* | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_does_nothing_if_movie_not_in_watchlist(): | ||
# Arrange | ||
movie_to_watch = HORROR_1 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
from viewing_party.party import * | ||
from tests.test_constants import * | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_my_unique_movies(): | ||
# Arrange | ||
amandas_data = clean_wave_3_data() | ||
|
@@ -16,7 +16,7 @@ def test_my_unique_movies(): | |
assert INTRIGUE_2 in amandas_unique_movies | ||
assert amandas_data == clean_wave_3_data() | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_my_not_unique_movies(): | ||
# Arrange | ||
amandas_data = clean_wave_3_data() | ||
|
@@ -28,7 +28,7 @@ def test_my_not_unique_movies(): | |
# Arrange | ||
assert len(amandas_unique_movies) == 0 | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_friends_unique_movies(): | ||
# Arrange | ||
amandas_data = clean_wave_3_data() | ||
|
@@ -43,7 +43,7 @@ def test_friends_unique_movies(): | |
assert FANTASY_4 in friends_unique_movies | ||
assert amandas_data == clean_wave_3_data() | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_friends_unique_movies_not_duplicated(): | ||
# Arrange | ||
amandas_data = clean_wave_3_data() | ||
|
@@ -54,12 +54,14 @@ def test_friends_unique_movies_not_duplicated(): | |
|
||
# Arrange | ||
assert len(friends_unique_movies) == 3 | ||
|
||
assert FANTASY_4 in friends_unique_movies | ||
assert HORROR_1 in friends_unique_movies | ||
assert INTRIGUE_3 in friends_unique_movies | ||
Comment on lines
+57
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
# ************************************************************************************************* | ||
# ****** Add assertions here to test that the correct movies are in friends_unique_movies ********** | ||
# ************************************************************************************************** | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_friends_not_unique_movies(): | ||
# Arrange | ||
amandas_data = { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
from viewing_party.party import * | ||
from tests.test_constants import * | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_new_genre_rec(): | ||
# Arrange | ||
sonyas_data = clean_wave_5_data() | ||
|
@@ -17,7 +17,7 @@ def test_new_genre_rec(): | |
assert FANTASY_4b in recommendations | ||
assert sonyas_data == clean_wave_5_data() | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_new_genre_rec_from_empty_watched(): | ||
# Arrange | ||
sonyas_data = { | ||
|
@@ -38,7 +38,7 @@ def test_new_genre_rec_from_empty_watched(): | |
# Assert | ||
assert len(recommendations) == 0 | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_new_genre_rec_from_empty_friends(): | ||
# Arrange | ||
sonyas_data = { | ||
|
@@ -52,12 +52,17 @@ def test_new_genre_rec_from_empty_friends(): | |
} | ||
] | ||
} | ||
# Act | ||
recommendations = get_new_rec_by_genre(sonyas_data) | ||
|
||
# Assert | ||
assert len(recommendations) == 0 | ||
Comment on lines
+56
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
# ********************************************************************* | ||
# ****** Complete the Act and Assert Portions of theis tests ********** | ||
# ********************************************************************* | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_unique_rec_from_favorites(): | ||
# Arrange | ||
sonyas_data = clean_wave_5_data() | ||
|
@@ -71,7 +76,7 @@ def test_unique_rec_from_favorites(): | |
assert INTRIGUE_2b in recommendations | ||
assert sonyas_data == clean_wave_5_data() | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_unique_from_empty_favorites(): | ||
# Arrange | ||
sonyas_data = { | ||
|
@@ -92,7 +97,7 @@ def test_unique_from_empty_favorites(): | |
# Assert | ||
assert len(recommendations) == 0 | ||
|
||
@pytest.mark.skip() | ||
# @pytest.mark.skip() | ||
def test_new_rec_from_empty_friends(): | ||
# Arrange | ||
sonyas_data = { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Keep an eye out for this on your future python projects as well.