Don't terminate the server when socket operation fails

[joka921]

No description provided.

[codecov]

Codecov Report

Patch coverage: 94.73% and no project coverage change.

Comparison is base (7920f8e) 74.07% compared to head (72bb26a) 74.07%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files         254      254           
  Lines       23991    23997    +6     
  Branches     3020     3021    +1     
=======================================
+ Hits        17771    17776    +5     
  Misses       5010     5010           
- Partials     1210     1211    +1     

Impacted Files	Coverage Δ
.../util/OnDestructionDontThrowDuringStackUnwinding.h	91.66% <75.00%> (-3.34%)	⬇️
src/parser/sparqlParser/SparqlQleverVisitor.cpp	87.55% <100.00%> (+0.01%)	⬆️
src/util/Synchronized.h	96.87% <100.00%> (ø)
src/util/http/HttpServer.h	72.54% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hannahbast]

Thanks a lot for this fix, here is a suggestion for the text for the commit message (for whowever merges the PR in the end):

When a socket operation was aborted, the closing of the socket threw an exception due to a subtle bug. That exception was then not caught and the server was terminated. The bug is now fixed and all exceptions are now caught by handling the cleanup with our own ad_utility::makeOnDestructionDontThrowDuringStackUnwinding instead of with absl::Cleanup.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication