Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better parsing for the words- and docsfile #1695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Flixtastic
Copy link
Contributor

Seperate PR to further improve the parsing during the textindex building.

@Flixtastic
Copy link
Contributor Author

One question I have is that I didn't find a solution to convert absl::StrSplit to a std::range or std::view and therefore resulted to using another cppcoro generator. I've seen the idea to avoid these generators but am I right that it is only possible to use these new Iterators through creating classes that implement them?

@sparql-conformance
Copy link

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 77.96610% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.83%. Comparing base (97c195a) to head (9c40084).

Files with missing lines Patch % Lines
src/parser/WordsAndDocsFileParser.cpp 65.71% 12 Missing ⚠️
src/index/IndexImpl.Text.cpp 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   89.84%   89.83%   -0.01%     
==========================================
  Files         389      389              
  Lines       37268    37284      +16     
  Branches     4202     4204       +2     
==========================================
+ Hits        33482    33494      +12     
- Misses       2485     2490       +5     
+ Partials     1301     1300       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant