Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower requirements for gcc and clang #1693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastian-wieczorek
Copy link

@joka921 Lower the requirements for gcc and clang for cpp17

@joka921
Copy link
Member

joka921 commented Dec 19, 2024

@sebastian-wieczorek
I have just started the automated checks, but I am somewhat expecting them to fail
(because even GCC 9.4 probably doesn't compile QLever in C++17 mode because of Coroutines and all the other things).

But a good idea would be to make the lowering of the versions dependent (at least for now) on a different parameter,
(independent from USE_CPP_17_BACKPORTS , and then add a separate GitHub Action that doesn't compile all of QLever, but only some explicit targets (those that already work with C++17, either because they are working out of the box, or because they have already been backported.)
But If you want we can discuss this further.

@sparql-conformance
Copy link

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (97c195a) to head (25e0ec2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
+ Coverage   89.84%   89.87%   +0.02%     
==========================================
  Files         389      389              
  Lines       37268    37268              
  Branches     4202     4202              
==========================================
+ Hits        33482    33493      +11     
+ Misses       2485     2478       -7     
+ Partials     1301     1297       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants