Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GROUP BY variables with parentheses or duplicates #1685

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Dec 16, 2024

With this change, grouped variables can be put in parentheses and still be used in the SELECT clause. For example, GROUP BY (?x) is now handled exactly like GROUP BY ?x. Additionally, we now deduplicate the grouped variables. For example, GROUP BY ?x ?x is now equivalent to GROUP BY ?x.

@sparql-conformance
Copy link

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (a97905e) to head (05f67f3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1685   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         389      389           
  Lines       37189    37197    +8     
  Branches     4196     4198    +2     
=======================================
+ Hits        33419    33427    +8     
- Misses       2473     2475    +2     
+ Partials     1297     1295    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hannahbast hannahbast changed the title Allow redundante parentheses around GROUP BY variables Allow redundant parentheses around GROUP BY variables Dec 16, 2024
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many bug fixes for Christmas, thanks!

@hannahbast hannahbast changed the title Allow redundant parentheses around GROUP BY variables Allow GROUP BY variables with parentheses or duplicates Dec 16, 2024
@hannahbast hannahbast merged commit 6429061 into ad-freiburg:master Dec 16, 2024
24 checks passed
@joka921 joka921 deleted the unused-braces-group-by branch December 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants