Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for materialized join results with lazy input with local vocabs #1684

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Dec 16, 2024

This fixes a subtle bug which led to a segmentation fault in the following scenario:

  1. The result of a join is fully materialized, but at least one of its inputs is lazy
  2. The blocks of the unique input contain local vocabs with unique entries (not shared between the blocks)
  3. There is at least one block in the lazy input that has no matching row in the other input, and therefore its local vocab is not used
  4. There is at least one block before the block from item 3 that is needed (including its local vocab)

Previously, the local vocabs from all blocks that fulfill item 3 were not part of the input and caused segfaults, when the corresponding local vocab pointer was dereferenced.

Fixes #1679

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (27f4799) to head (c6f3d45).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   89.76%   89.86%   +0.10%     
==========================================
  Files         389      389              
  Lines       37149    37190      +41     
  Branches     4194     4197       +3     
==========================================
+ Hits        33346    33422      +76     
+ Misses       2502     2472      -30     
+ Partials     1301     1296       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! Slight improvement of a comment

@sparql-conformance
Copy link

@hannahbast hannahbast changed the title Fix #1679 Fix bug for materialized join results with lazy input with local vocabs Dec 16, 2024
@hannahbast hannahbast merged commit e422852 into ad-freiburg:master Dec 16, 2024
22 checks passed
Copy link

@joka921 joka921 deleted the fix-bug-local-vocab-join branch December 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPTIONAL + BIND(IF(BOUND)) crashes qlever
2 participants