Fix bug for UNION with SUBQUERY with invisible variables #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Kalmbach <[email protected]>
Conformance check passed ✅No test result changes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1682 +/- ##
==========================================
- Coverage 89.76% 89.75% -0.01%
==========================================
Files 389 389
Lines 37149 37150 +1
Branches 4194 4194
==========================================
- Hits 33346 33344 -2
- Misses 2502 2506 +4
+ Partials 1301 1300 -1 ☔ View full report in Codecov by Sentry. |
hannahbast
approved these changes
Dec 16, 2024
hannahbast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the following scenario: a UNION that is lazily computed and at least one of the inputs of the UNION contains a subquery that does not SELECT all possible variables. Then the UNION threw an assertion, because there was some confusion between the number of visible variables in the input (only the ones selected by the subquery) and the actual number of columns in the result (which includes the not-selected variables of the subquery).
Fixes #1681