Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InputRange... classes as a replacement for cppcoro::generator #1678

Merged
merged 15 commits into from
Dec 16, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Dec 13, 2024

The new classes (called InputRange...) and their requirements can be found in src/util/iterators.h. They can be used to replace our many uses of cppcoro::generator.

For an example, see src/engine/Result.h, where using LazyResult = ad_utility::InputRangeTypeErased<IdTableVocabPair> is defined as a replacement for using Generator = cppcoro::generator<IdTableVocabPair>, and the many places where now LazyResult is used instead of Generator.

Other replacements will take a little more work.

Signed-off-by: Johannes Kalmbach <[email protected]>
# Conflicts:
#	src/util/Views.h
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 91.81818% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.86%. Comparing base (4237e0d) to head (91e6523).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/util/Iterators.h 87.69% 5 Missing and 3 partials ⚠️
src/util/Views.h 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
+ Coverage   89.69%   89.86%   +0.16%     
==========================================
  Files         385      389       +4     
  Lines       36955    37268     +313     
  Branches     4179     4201      +22     
==========================================
+ Hits        33148    33492     +344     
+ Misses       2507     2479      -28     
+ Partials     1300     1297       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic and looks ready to merge now (assuming that the tests run through)

@sparql-conformance
Copy link

@hannahbast hannahbast changed the title Add utilities for the simple creation of input ranges. Add InputRange... classes as a replacement for cppcoro::generator Dec 16, 2024
@hannahbast hannahbast merged commit 332d8e5 into ad-freiburg:master Dec 16, 2024
22 checks passed
@joka921 joka921 deleted the simple-input-ranges branch December 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants