-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InputRange...
classes as a replacement for cppcoro::generator
#1678
Conversation
…es easier. Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
# Conflicts: # src/util/Views.h
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
+ Coverage 89.69% 89.86% +0.16%
==========================================
Files 385 389 +4
Lines 36955 37268 +313
Branches 4179 4201 +22
==========================================
+ Hits 33148 33492 +344
+ Misses 2507 2479 -28
+ Partials 1300 1297 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
…-input-ranges # Conflicts: # src/util/Views.h
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic and looks ready to merge now (assuming that the tests run through)
Conformance check passed ✅No test result changes. |
InputRange...
classes as a replacement for cppcoro::generator
Quality Gate passedIssues Measures |
The new classes (called
InputRange...
) and their requirements can be found insrc/util/iterators.h
. They can be used to replace our many uses ofcppcoro::generator
.For an example, see
src/engine/Result.h
, whereusing LazyResult = ad_utility::InputRangeTypeErased<IdTableVocabPair>
is defined as a replacement forusing Generator = cppcoro::generator<IdTableVocabPair>
, and the many places where nowLazyResult
is used instead ofGenerator
.Other replacements will take a little more work.