Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cost estimate of SORT to not prefer binary search filters with large results #1663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Dec 5, 2024

No description provided.

@joka921 joka921 marked this pull request as ready for review December 5, 2024 12:24
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.85%. Comparing base (332d8e5) to head (702f410).

Files with missing lines Patch % Lines
src/engine/Sort.cpp 88.88% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   89.87%   89.85%   -0.02%     
==========================================
  Files         389      389              
  Lines       37268    37289      +21     
  Branches     4202     4205       +3     
==========================================
+ Hits        33493    33507      +14     
- Misses       2478     2481       +3     
- Partials     1297     1301       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparql-conformance
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant