Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lazy Distinct operation #1558

Merged
merged 15 commits into from
Oct 26, 2024
Merged

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Oct 15, 2024

Allow the Distinct operation to deal with lazy inputs.
Note: DISTINCT currently always assumes a sorted input, so the laziness doesn't yet happen too often in practice.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 88.03419% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (2ccfb50) to head (b63fff2).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/Distinct.cpp 87.38% 0 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
- Coverage   89.04%   89.03%   -0.01%     
==========================================
  Files         368      368              
  Lines       33972    34095     +123     
  Branches     3839     3858      +19     
==========================================
+ Hits        30249    30356     +107     
  Misses       2471     2471              
- Partials     1252     1268      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review on everything but the tests.

src/engine/Distinct.h Outdated Show resolved Hide resolved
src/engine/Distinct.h Show resolved Hide resolved
src/engine/Distinct.cpp Show resolved Hide resolved
src/engine/Distinct.cpp Outdated Show resolved Hide resolved
src/engine/Distinct.cpp Outdated Show resolved Hide resolved
src/engine/Distinct.cpp Outdated Show resolved Hide resolved
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small requests

  • can you please merge in the current master, s.t. we get a proper Codecov report?

src/engine/Distinct.cpp Show resolved Hide resolved
test/engine/DistinctTest.cpp Show resolved Hide resolved
@sparql-conformance
Copy link

Copy link

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage is very hard to track because of te many templates of the callFixedSize optimization.

@joka921 joka921 merged commit db089f8 into ad-freiburg:master Oct 26, 2024
20 of 22 checks passed
@RobinTF RobinTF deleted the lazy-distinct branch October 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants