-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lazy Distinct
operation
#1558
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
- Coverage 89.04% 89.03% -0.01%
==========================================
Files 368 368
Lines 33972 34095 +123
Branches 3839 3858 +19
==========================================
+ Hits 30249 30356 +107
Misses 2471 2471
- Partials 1252 1268 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review on everything but the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small requests
- can you please merge in the current master, s.t. we get a proper Codecov report?
Conformance check passed ✅No test result changes. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage is very hard to track because of te many templates of the callFixedSize
optimization.
Allow the
Distinct
operation to deal with lazy inputs.Note:
DISTINCT
currently always assumes a sorted input, so the laziness doesn't yet happen too often in practice.