-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the implementation of the SpatialJoin
operation into a separate class
#1552
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
- Coverage 88.47% 88.47% -0.01%
==========================================
Files 363 364 +1
Lines 27533 27534 +1
Branches 3714 3714
==========================================
Hits 24361 24361
Misses 1940 1940
- Partials 1232 1233 +1 ☔ View full report in Codecov by Sentry. |
Conformance check passed ✅No test result changes. |
Quality Gate passedIssues Measures |
SpatialJoin
operation into a separate class
This makes the code cleaner by separating the boilerplate required as a subclass of
Operation
from the actual geometric calculations. It also makes the development much more convenient, as changing details in the implementation doesn't require the recompilation of the completeengine
library.