Refactoring preliminaries for lazy operations (Part 1) #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
- Coverage 88.79% 88.78% -0.02%
==========================================
Files 324 324
Lines 28650 28673 +23
Branches 3170 3171 +1
==========================================
+ Hits 25441 25456 +15
- Misses 2060 2065 +5
- Partials 1149 1152 +3 ☔ View full report in Codecov by Sentry. |
joka921
reviewed
May 21, 2024
joka921
requested changes
May 22, 2024
|
joka921
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes from the infrastructure for lazy operation evaluation (#1350) that are simple and repetitive, but touch many files. In particular:
ResultTableclass toResult(a TODO suggested by @hannahbast some time ago).bool requestLazinesstoOperation::computeResult. This parameter is currently unused.