Add triples of ql:has-pattern predicate to PSO and POS
#1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
+ Coverage 84.33% 84.34% +0.01%
==========================================
Files 304 304
Lines 29058 29100 +42
Branches 3437 3446 +9
==========================================
+ Hits 24505 24544 +39
Misses 3153 3153
- Partials 1400 1403 +3 ☔ View full report in Codecov by Sentry. |
hannahbast
changed the title
ql:has-pattern predicate.ql:has-pattern predicate
hannahbast
requested changes
Jan 17, 2024
hannahbast
changed the title
ql:has-pattern predicateql:has-pattern predicate to PSO and POS
|
hannahbast
pushed a commit
that referenced
this pull request
Jan 18, 2024
…tern` into RAM (#1223) PRs #1168 and #1177 have added the subject patterns as two additional columns to the OSP&OPS and PSO&POS permutations. PR #1226 has added the triples of the `ql:has-pattern` predicate to the PSO&POS permutations. Now use this information instead of the old patterns, which did cost a lot of RAM. We tried a few queries involving patterns and the speed is very similar to that of the previous implementation. NOTE: This is an index-breaking change. The old `.index.patterns` file stored the `ql:has-pattern` predicate (for each subject its pattern) and the information which pattern consists of which predicates. Now the `.index.patterns` file only stores the latter information. The file size therefore is significantly reduced and no longer depends on the size of the dataset (but only on how many distinct patterns there are, typically few). For example, for Wikidata, the file size reduced from 17 GB to 2.8 GB. For UniProt, the reduction is from 152 GB (which does not fit into the RAM of our standard machines) to something very small (because UniProt is very regular and there are only very few distinct patterns).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PSO and POS permutation now also contain the triples of the internal
ql:has-patternpredicate. These will be used as a fallback for the new pattern implementation (which will come with one of the next commits). Note that we don't need the triples in the other four permutations, so the pair PSO&POS now has more triples than SPO&SOP and OSP&OPS.