Skip to content

Commit

Permalink
Improve comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Hannah Bast committed Dec 16, 2024
1 parent 7f6b823 commit c6f3d45
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions src/engine/AddCombinedRowToTable.h
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,12 @@ class AddCombinedRowToIdTable {
AD_CORRECTNESS_CHECK(inputLeftAndRight_.has_value());
flush();
} else if (resultTable_.empty()) {
// Clear vocab when no rows were written.
// TODO<joka921, robinTF> We could optize the case that there were no
// calls to `addRow` for the current input, but we still have rows in the
// `resultTable_` from previous inputs. Possibly we could only merge in
// the local vocab from the inputs when calling `flush` the first time,
// and not right when on `setInput`. But this requires further thought and
// thinking, while this comment was written as part of a crucial bugfix.
// Clear local vocab when no rows were written.
//
// TODO<joka921, robinTF> This is a conservative approach. We could
// optimize this case (clear the local vocab more often, but still
// correctly) by considering the situation after all the relevant inputs
// have been processed.
mergedVocab_ = LocalVocab{};
}
}
Expand Down

0 comments on commit c6f3d45

Please sign in to comment.