-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword search to filter example queries #83
Merged
hannahbast
merged 15 commits into
ad-freiburg:master
from
IoannisNezis:keyword-search-for-examples
Aug 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6237527
added keyword search to filter example querys
IoannisNezis 96d7bac
refactor: moved keyword-search into separate file
IoannisNezis cc09553
refactor: renamed keyword search highlight class
IoannisNezis 6ff01ae
enhancement: themed keyword-search-highlight
IoannisNezis 60be87b
fix: fixing bug in keyword-search section consolidation
IoannisNezis 3d677fe
enhancement: debounced keyword-search
IoannisNezis 711395d
enhancement: focus input on dropdown
IoannisNezis 0175a39
enhancement: better docstrings for keyword search
IoannisNezis 5222980
enhancement: regex based keyword search
IoannisNezis bfda835
fix: adjusting comment style
IoannisNezis 597548a
refactor: moved keyword search input event handler to js
IoannisNezis 797f910
enhancement: keyboard controls for keyword-search
IoannisNezis 0831b5c
formatting keywordSearch code
IoannisNezis 2dc99ef
fix: catch SyntaxError properly
IoannisNezis b3ac1da
Revert db/qleverui.sqlite3 to version from origin/master
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enhancement: focus input on dropdown
- Loading branch information
commit 711395d8452296b840a8c8381c89d3ea2ec79e01
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment: Our comment style is normal sentences (capitalized and with a full stop). I know that a lot of the qlever-ui does not follow this rule yet. That's becase it's old. But nor reason not to stick to this for all new code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good to know!
I generated some docstrings with chatGPT.
Do the new comments satisfy the comment style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use ordinary
// ...
comments with full sentences. When referring to variable or class names in a comment, we put it in...
. See the code on https://github.com/ad-freiburg/qlever for many examples of this (it's also not 100% consistent there, but 90% of the comments follow this convention).