Fix wild behavior when SELECT is missing + other improvements in this vein
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 10, 2024 05:53
Without typing at least a few characters, it's more confusing than helpful to suggest a subject AC query to the user. It is currently hard-coded that at least 3 characters have to be typed, but this should be a configurable parameter.
…sor-when-SELECT-missing
PR merged for testing, but is not part of this PR
Some of the useful automatic features of the query editor went rogue under certain conditions. Two things are now fixed or at least better: 1. When the query did not contain `SELECT` in all upper case and one of the existing prefixes was typed, each cursor movement would be followed by a reveral of that movement, which made the UI unusable. This is now fixed. 2. So far, the query was "cleaned up" (blank lines removed, whitespace replaced by single spaces, etc.) after *every* cursor movement, which was not always desired. Now the query is only cleaned up in this way when the `TAB` key is pressed (which jumps between the different positions in the placeholder). 3. Some REGEXes were only looking for fully uppercases version of SPARQL keywords like WHERE, etc. Now the are case-insensitive.
hannahbast
changed the title
SELECT is missing + more fixes
hannahbast
changed the title
SELECT is missing + more fixesSELECT is missing + other improvements in this vein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the useful automatic features of the query editor went rogue under certain conditions. Three things are now fixed or at least better:
When the query did not contain
SELECTin all upper case and one of the existing prefixes was typed, each cursor movement would be followed by a reversal of that movement, which made the UI unusable. This is now fixed. In particular, this fixes Cursor jumps around while typing #57.So far, the query was "cleaned up" (blank lines removed, whitespace replaced by single spaces, etc.) after every cursor movement, which was not always desired. Now the query is only cleaned up in this way when the
TABkey is pressed (which jumps between the different positions in the placeholder). In particular, this fixes New lines sometimes get deleted when moving the cursor immediately afterwards #63.Some REGEXes were only looking for a fully uppercase version of SPARQL keywords like
WHERE, etc. Now they are case-insensitive.