Don't ignore db when building Docker image
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ignore this for our local image because there we mount the `db` directory as a volume. But for the Docker build and push action, it should of course not be ignored.
IoannisNezis
added a commit
to IoannisNezis/qlever-ui
that referenced
this pull request
Sep 1, 2024
* master: Don't ignore `db` when building Docker image (ad-freiburg#101) Update deprecated setting for static storage (ad-freiburg#95) Build and push Docker image after each commit to the master (ad-freiburg#98) Update db/qleverui.sqlite3 to latest configs and example queries Display details for operation in "Analysis" tree as tooltip (ad-freiburg#80) Bump dependencies `requests`, `gunicorn`, `django` to latest version Improvements in Docker setup (ad-freiburg#90) Add keyword search to filter example queries (ad-freiburg#83) Restore default qleverui.sqlite3 Fix regex in replacePredicatesList No subject AC query for short prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore this for our local image because there we mount the
dbdirectory as a volume. But for the Docker build and push action, it should of course not be ignored. This should fix #99