Parse folded POINT geometries from QLever IDs dynamically #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query result and ignoring POINTs in geometry filling, seems to work pretty well so far
…\" was misleading, separate log messages for geometries received from cache, and points received dynamically from query result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, petrimaps does not fill the geometry cache with
POINTgeometries any more. These are now folded into the internal IDs in QLever, and petrimaps reads them dynamically from the query result.We also try to avoid caching of queries with non-deterministic results by skipping caching altogether if
rand()is present in the lowercased query.