Add option to fetch geometries via geo:hasGeometry/geo:asWKT
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the code supported getting the geometries via `geo:hasGeometry` (old osm2rdf style) and via `wdt:P625` (Wikidata style). Since November, the TTLs provided on https:/osm2rdf.cs.uni-freiburg.de provide the geometries via geo:hasGeometry/geo:asWKT, which is now also supported. TODO: The selection between is currently hard-coded, based on the name of the backend. We should find a more elegant and robust mechanism for this.
hannahbast
changed the title
geo:hasGeometry/asWKT
hannahbast
changed the title
geo:hasGeometry/asWKTgeo:hasGeometry/geo:asWKT
…plicates, update util lib, don't output WKT bbox in log if box is empty (ugly)
|
I change the log level of the duplicate report to DEBUG to avoid millions of log entries, a cumulative number of duplicates is now also outputted. Additional minor changes: for request with either no lines or no points, the line or point bounding box were outputted with their "empty" values, which are based on |
patrickbr
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the code supported getting the geometries via
geo:hasGeometry(old osm2rdf style) and viawdt:P625(Wikidata style). Since November, the TTLs provided on https:/osm2rdf.cs.uni-freiburg.de provide the geometries via geo:hasGeometry/geo:asWKT, which is now also supported.TODO: The selection between is currently hard-coded, based on the name of the backend. We should find a more elegant and robust mechanism for this.