Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: store the composition as nodes in the runtime #105

Merged
merged 17 commits into from
Dec 5, 2024
Merged

feat!: store the composition as nodes in the runtime #105

merged 17 commits into from
Dec 5, 2024

Conversation

matthunz
Copy link
Collaborator

@matthunz matthunz commented Dec 4, 2024 •
edited
Loading

  • Store the composition as nodes in the runtime
  • Impl Iterator for Composer to step through re-compositions
  • Drop composables in reverse order to simulate the original behavior
  • Skip directly to composables with a pending queue
  • Make Runtime struct private
  • Update composables:
    • Memo
    • (T1..T8)
    • Option
    • Result
    • FromIter
    • DynCompose

@matthunz matthunz added enhancement New feature or request core experimental labels Dec 4, 2024
@matthunz matthunz changed the title Store pointers to the composition feat: store pointers to the composition Dec 4, 2024
@matthunz matthunz changed the title feat: store pointers to the composition feat: store the composition as nodes in the runtime Dec 5, 2024
@matthunz matthunz changed the title feat: store the composition as nodes in the runtime feat!: store the composition as nodes in the runtime Dec 5, 2024
matthunz added 17 commits December 4, 2024 21:07
@matthunz
feat!: impl Iterator for Composer to step through re-compositions
de72b50
@matthunz
refactor: pass lints
1b57754
@matthunz
fix: composer example
fb04e56
@matthunz
fix: drop scopes in reverse order to keep current behavior and remove…
86205c9 
… Compose impl for RefMap
@matthunz
feat: update compose impl for tuples
af1ad62
@matthunz
fix: reborrow composables inside a tuple
e3f0958
@matthunz
fix: change pending queue to FIFO and pass lints
e7ba724
@matthunz
refactor!: make Runtime private and clean up
1afa8a9
@matthunz
feat: update Memo composable
4405853
@matthunz
refactor: remove unused flags from ScopeData
b88e5b5
@matthunz
feat: update Option and Result
204444c
@matthunz
feat: store the composition as nodes in the runtime
2de7b1b
@matthunz
feat!: step through the composition with Composer::try_compose
b8eb635
@matthunz
feat: update FromIter composable
930e322
@matthunz
feat: update DynCompose and track parent keys
f743a1d
@matthunz
fix: drop child key on removal in Option and skip allocating Nodes fo…
e46a859 
…r ()
@matthunz
refactor: clean up
cf1a387
@matthunz matthunz merged commit 9ef73eb into main Dec 5, 2024
4 checks passed
@matthunz matthunz deleted the tree branch December 11, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core enhancement New feature or request experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthunz