Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 attempt 2 #22

Merged
merged 12 commits into from
Nov 15, 2022
Merged

1.0 attempt 2 #22

merged 12 commits into from
Nov 15, 2022

Conversation

MatthewCaseres
Copy link
Collaborator

I force pushed something with Git LFS and it made a bit of a mess, trying again.

The XML is like 70 MB and I am ok with that. After 100 refreshes of the data and the repo is like 8GB then maybe it is an issue but I think the XML can stay for now.

I did my best to remove the pycache files, and updates gitattributes with the linguist stuff.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (bcc6dc0) compared to base (8a2fdf6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         4    -2     
  Lines          166       116   -50     
=========================================
- Hits           166       116   -50     
Impacted Files Coverage Δ
pymort/__init__.py 100.00% <100.00%> (ø)
tests/test_pymort.py 100.00% <100.00%> (ø)
pymort/XML.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatthewCaseres
Copy link
Collaborator Author

Gave it another look and did some more cleanup. should be good

@MatthewCaseres MatthewCaseres merged commit e55d6b2 into main Nov 15, 2022
Copy link
Member

@jimbrig jimbrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MatthewCaseres MatthewCaseres deleted the 1.0_attempt_2 branch November 19, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants