Multiuser and OpenId

[lelemm]

No description provided.

[netlify]

✅ Deploy Preview for actualbudget-website ready!

Name	Link
🔨 Latest commit	2508f20
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget-website/deploys/676a297f31d7060008c1d828
😎 Deploy Preview	https://deploy-preview-447.www.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[RubenOlsen]

I hope I have not been to crass in my comments and suggestions.

Also please do not use the backtick when referring to elements in the UI, use italics or bold to reference the elements and bold or italics to reference the content of the elements. Italics are preferred over bold to reference elements.

[lelemm]

@RubenOlsen thanks for your dedication on this. Took this long for me to notice that you reviewed this.
There was multiple changes on how multiuser and openid was implemented since this PR. I'm waiting for the frontend PR be approved, than I will come back to this.

[lelemm]

@MikesGlitch this doc is completely wrong atm. I have to redo it. Since code review started I changed the functionality so much.
For example: there is no more env variables/config.json for this for 2 reasons:

• multiuser was removed. We now consider that if openid is enabled, multiuser is enabled by default
• the openid config.json configurations was removed because now we have fallback authentication. In other words, you ALWAYS have to do the server password bootstrap to enable openid from the settings after.

[lelemm]

@RubenOlsen @MikesGlitch
This has a conflict because the "Advanced" menu does not exists anymore.
Where This two pages must go in the menu so I can resolve the conflict?

[youngcw]

@RubenOlsen @MikesGlitch This has a conflict because the "Advanced" menu does not exists anymore. Where This two pages must go in the menu so I can resolve the conflict?

I think it should go under Installation and Configuration

[lelemm]

@RubenOlsen @MikesGlitch This has a conflict because the "Advanced" menu does not exists anymore. Where This two pages must go in the menu so I can resolve the conflict?

I think it should go under Installation and Configuration

done

[matt-fidd]

@RubenOlsen @MikesGlitch This has a conflict because the "Advanced" menu does not exists anymore. Where This two pages must go in the menu so I can resolve the conflict?

I think it should go under Installation and Configuration

@youngcw - do you have any objection to this being moved under "Experimental" so it can't be misconstrued as stable?

[youngcw]

@RubenOlsen @MikesGlitch This has a conflict because the "Advanced" menu does not exists anymore. Where This two pages must go in the menu so I can resolve the conflict?

I think it should go under Installation and Configuration

@youngcw - do you have any objection to this being moved under "Experimental" so it can't be misconstrued as stable?

Yeah that would be best

[matt-fidd]

A few comments

Could you update the images with the recent UI changes too please?
There's also one spellcheck alert left

Thanks for your work on this

[matt-fidd]

Could this be moved under experimental and have the experimental banner (can be found in the other pages) added to the top please?

[lelemm]

moved to experimental, accepted all suggestions, added banner, and some changes for github authentication.

please check it now

[youngcw]

Its still a bit spartan, but it seems fine for now. We should have something in by the time of the release, so feel free to add to this before then. If not its approved and ready to merge at release.

[youngcw]

Is the config file or env vars optional? I made a config file, but then the in app setup asked for the same information. It those extra config settings are optional, then maybe that should be made clear in the docs.

[lelemm]

Is the config file or env vars optional? I made a config file, but then the in app setup asked for the same information. It those extra config settings are optional, then maybe that should be made clear in the docs.

They are optional. Or you config using the file plus command line or all using the ui