Fix calendar report day background colour in development theme

[matt-fidd]

Before:

After:

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	0963359
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6776c29cc603c80008bae915
😎 Deploy Preview	https://deploy-preview-4073.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.64 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	10.24 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/narrow.js	83.36 kB	0%
static/js/wide.js	104.11 kB	0%
static/js/ReportRouter.js	1.58 MB	0%
static/js/index.js	3.71 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

[matt-fidd]

updated to match light theme

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/desktop-client/src/style/themes/development.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eslint-plugin".

(The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eslint-plugin@latest --save-dev

The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request involves a modification to the calendarCellBackground color variable in the development theme file for the desktop client. Specifically, the background color for calendar cells has been changed from colorPalette.navy900 (a dark navy shade) to colorPalette.navy100 (a much lighter navy shade). This change is localized to the theme configuration in the development theme file, which will impact the visual appearance of calendar cells in the user interface when the development theme is active.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e65939 and 0963359.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4073.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/style/themes/development.ts (1 hunks)

🧰 Additional context used

📓 Learnings (1)

packages/desktop-client/src/style/themes/development.ts (1)

Learnt from: lelemm
PR: actualbudget/actual#3828
File: packages/desktop-client/src/style/themes/development.ts:217-217
Timestamp: 2024-11-12T18:16:38.183Z
Learning: In `packages/desktop-client/src/style/themes/development.ts`, the constants `calendarCellBackground` and `calendarBackground` are used for different calendar components, so they may share the same color value.

🔇 Additional comments (1)

packages/desktop-client/src/style/themes/development.ts (1)

217-217: Ensure contrast and consistency with other calendar colors.

Switching calendarCellBackground from navy900 (dark) to navy100 (light) can drastically alter the calendar’s appearance. Please verify that text remains legible (e.g., calendarText = colorPalette.navy50) and that this lighter shade aligns with surrounding calendar backgrounds, such as calendarBackground = colorPalette.navy900.

Run the following script to check all references to calendarCellBackground, calendarBackground, and calendarText to verify consistent usage and suitable contrast:

✅ Verification successful

Let me analyze the color relationships in the themes to verify the contrast and consistency.

---

Let me try a different approach to find the color definitions.

---

Calendar color scheme is consistent with theme design patterns

Based on the analysis of the theme files, the change of calendarCellBackground to navy100 in the development theme is consistent with the design patterns:

• The light theme also uses navy100 for calendar cells, showing this is an intentional design choice for lighter themes
• The dark and midnight themes use navy900 for calendar cells, maintaining the dark/light contrast pattern
• The calendar text color is set to navy50 (very light) which provides good contrast against navy100 (light) background
• The overall calendar hierarchy is maintained:
  • Calendar background: navy900 (darkest)
  • Calendar item background: navy800 (dark)
  • Calendar cell background: navy100 (light)
  • Calendar text: navy50 (lightest)

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# This script searches for references to calendar background colors in the codebase.
rg -A 4 'calendarCellBackground|calendarBackground|calendarText'

Length of output: 4456

---

Script:

#!/bin/bash
# Let's check the color palette definitions to understand the contrast levels
rg -A 20 'colorPalette = {' packages/desktop-client/src/style/themes/

Length of output: 167

---

Script:

#!/bin/bash
# Let's check the color palette definitions, escaping the curly brace
rg -A 20 "colorPalette = \{" packages/desktop-client/src/style/themes/

Length of output: 72

---

Script:

#!/bin/bash
# Search for navy color definitions in the palette
rg "navy\d+" packages/desktop-client/src/style/themes/

Length of output: 22904

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.