-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YTD and last year to Reports headers #4019
Changes from all commits
97e5d90
08d75b9
3e1d7e7
26c2b37
585d042
290058a
121d09b
f4973c8
690627e
39a5d2e
9891c7d
20cdd51
0d0068c
3062cb5
239e180
62ce389
18dc0fe
9e78272
e6b49ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import { type RuleConditionEntity } from './rule'; | |
export type TimeFrame = { | ||
start: string; | ||
end: string; | ||
mode: 'sliding-window' | 'static' | 'full'; | ||
mode: 'sliding-window' | 'static' | 'full' | 'lastYear' | 'yearToDate'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this necessary? The existing mode types are for how the window functions. Plus the existing window options aren't in this list, so it seems like you shouldn't need to change this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The problem is. Sliding window will be always against current month. In my opinion we could migrate it to other structure to be more productive but we can’t because they are already being used. we should get the interval size, interval type and anchor. or Two years |
||
}; | ||
|
||
type AbstractWidget< | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
category: Enhancements | ||
authors: [rodriguestiago0] | ||
--- | ||
|
||
Add "Year to date" and "Last year" to reports header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we up this? I think it looks a bit squished.
Current:
Here's 10px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small screens would have a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way to force it to wrap when the save button starts to overlap with the filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. my knowledge of CSS is less than js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, we'll go with it for now then. If anyone works out a way it can be a separate PR