Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (synced-prefs) refactor number formatter away from redux #3397

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

MatissJanis
Copy link
Member

Depends on #3395

@actual-github-bot actual-github-bot bot changed the title ♻️ (synced-prefs) refactor number formatter away from redux [WIP] ♻️ (synced-prefs) refactor number formatter away from redux Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 5.22 MB → 5.21 MB (-8.5 kB) -0.16%
Changeset
File Δ Size
src/components/spreadsheet/useFormat.ts 📈 +364 B (+27.96%) 1.27 kB → 1.63 kB
src/hooks/useDateFormat.ts 📈 +9 B (+9.78%) 92 B → 101 B
home/runner/work/actual/actual/packages/loot-core/src/shared/util.ts 📈 +5 B (+0.07%) 6.58 kB → 6.58 kB
src/hooks/useFeatureFlag.ts 📉 -46 B (-11.79%) 390 B → 344 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/prefs.ts 📉 -671 B (-54.03%) 1.21 kB → 571 B
node_modules/reselect/es/index.js 🔥 -4.13 kB (-100%) 4.13 kB → 0 B
node_modules/reselect/es/defaultMemoize.js 🔥 -3.64 kB (-100%) 3.64 kB → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/selectors.ts 🔥 -418 B (-100%) 418 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.26 MB → 3.25 MB (-8.5 kB) -0.25%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 1.59 kB 0%
static/js/AppliedFilters.js 21.01 kB 0%
static/js/narrow.js 78.68 kB 0%
static/js/wide.js 224.58 kB 0%
static/js/ReportRouter.js 1.49 MB 0%

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.19 MB 0%
Changeset
File Δ Size
packages/loot-core/src/shared/util.ts 📈 +5 B (+0.05%) 10.53 kB → 10.54 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.19 MB 0%

Base automatically changed from matiss/synced-prefs-1 to master September 8, 2024 20:42
@MatissJanis MatissJanis changed the title [WIP] ♻️ (synced-prefs) refactor number formatter away from redux ♻️ (synced-prefs) refactor number formatter away from redux Sep 8, 2024
Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a8200b7
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66de194465ee630008dc5c03
😎 Deploy Preview https://deploy-preview-3397.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatissJanis MatissJanis merged commit 8498d7f into master Sep 9, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/synced-prefs-3 branch September 9, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants