Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include hidden Categories when adding transactions #1914

Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,16 @@
...(!embedded && { maxHeight: 175 }),
}}
>
{items.map((item, idx) => {
{items.filter(item => !item.hidden)

Check warning on line 49 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Insert `⏎··········`
.map((item, idx) => {

Check warning on line 50 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Replace `··············` with `··········`
ioslife marked this conversation as resolved.
Show resolved Hide resolved
if (item.id === 'split') {

Check warning on line 51 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Insert `··`
return (

Check warning on line 52 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Insert `··`
<View

Check warning on line 53 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Replace `··············` with `················`
key="split"

Check warning on line 54 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Insert `··`
{...(getItemProps ? getItemProps({ item }) : null)}

Check warning on line 55 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Insert `··`
// Downshift calls `setTimeout(..., 250)` in the `onMouseMove`

Check warning on line 56 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Replace `················` with `··················`
// event handler they set on this element. When this code runs

Check warning on line 57 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Insert `··`
// in WebKit on touch-enabled devices, taps on this element end

Check warning on line 58 in packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / lint

Replace `················` with `··················`
// up not triggering the `onClick` event (and therefore delaying
// response to user input) until after the `setTimeout` callback
// finishes executing. This is caused by content observation code
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/1914.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Features
authors: [iOSLife]
---

Adds a filter on the item list in the CategoryAutocomplete component. This will prevent users from accidentally adding a transaction to a hidden category.
Loading