Color Consolidations #1868
Color Consolidations #1868
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
carkom
force-pushed
the
colorConsolidations
branch
from
9ce41d5 to
feddce0
Compare
|
Only one small regression here. The rest of the work is re-naming and re-organizing the theme colors. A slight visual regression in the settings page as it was using a border color that wasn't being used anywhere else in the app. I choose to match the color standardization that is used everywhere else in the app rather than have this be an entirely unique element not used anywhere else. Cheers! |
|
Ill approve this once the conflicts are cleared up. We probably should get another approval though because of the small change. |
|
Just looking at the screenshots: it seems the border for checkboxes is now wrong. Looks like it always highlights them as "active" even if the user is not actively using them. Also - I'm not really a fan of the removal of the border. Could we instead use a different color for it from the existing palette instead of removing them entirely? |
Fixed both, thanks for the review. Let me know if ready to merge or if there's any other changes needed. |
|
New warning color looks much better! Thanks for taking care of that too!
This one isn't done yet. The new border for settings block is either transparent or just too light (in lightmode) compared to before. |
This reverts commit ae58317.
I made it a shade darker in light mode. LMK! |
|
Settings page card border now looks good. But the checkbox border issue is back. |
Yep, I see what I did there. Accidently reverted the fix. It's back in now. 😬 |
trafico-bot
bot
added
✨ Merged
* Color normalization * color updates * VRT updates * update colors table * VRT updates * more VRT updates * pillborder * VRT updates * Revert "VRT updates" This reverts commit ae58317. * Revert "more VRT updates" This reverts commit a316745. * Revert "VRT updates" This reverts commit 03797af. * Revert "VRT updates" This reverts commit 454adac. * VRT refresh * border color * Checkbox Border * VRT updates
Consolidating colors so they are more consistent across the app from one page to the next. This also helps with staging dark theme colors.