2 new vrt tests for reports #1814
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| const viewportSize = await page.viewportSize(); | ||
| await page.mouse.move(viewportSize.width / 2, viewportSize.height / 2); | ||
|
|
||
| await expect(page).toHaveScreenshot(screenshotConfig(page)); |
There was a problem hiding this comment.
💬 suggestion: would creating screenshots of only the popover make the tests more stable?
There was a problem hiding this comment.
I changed it to take screenshots of the overall page instead of trying to include the tooltips. I tried add test-ids to the tooltips and taking screenshots of those as well, but it was also flaky. I think this is good enough for now
trafico-bot
bot
added
✨ Merged
Doesn't fix #1813, but will prevent it from happening in the future.