Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Category Notes - Reveal on hover #563

Closed
rich-howell opened this issue Jan 22, 2023 · 6 comments · Fixed by #579
Closed

[Feature] Category Notes - Reveal on hover #563

rich-howell opened this issue Jan 22, 2023 · 6 comments · Fixed by #579
Labels
feature This issue is a feature request

Comments

@rich-howell
Copy link
Contributor

Discussed in https://github.com/actualbudget/actual/discussions/344

Originally posted by Kidglove57 December 1, 2021
When allocating budgeted amounts each month, I rely on my category notes which are helpfully stored in the budget screen. At present I need to click into each note individually to check the amount. It would be SO helpful if my notes could be revealed by just hovering the mouse over the notes icon instead. See YNAB4 purely as an example of where this has been done before.

@rich-howell rich-howell added the feature This issue is a feature request label Jan 22, 2023
@TechwizEE
Copy link

Agreed on making it easier to reveal the notes. Would this "hover view" also be the way to edit the notes? Or would it still required a click? (Seems a click might help prevent accidental editing)

@Kidglove57
Copy link

100% agree on click to edit note.
I would use the hover mainly to double check the note for what I need to enter as a new month category budget amount.

@gsumpster
Copy link
Contributor

gsumpster commented Jan 27, 2023

Hey, I was interested in taking a stab at this, here's what I put together.

CleanShot 2023-01-27 at 01 20 16

The preview tooltip will pop up on hover of the notes button and display the tooltip (smaller, limited to 220px in width, not restricted on height). If you move your cursor into the text, you'd be able to copy and interact with the text without the tooltip disappearing (easy to change, but think this would be my preference!). Clicking on the notes button will flip the tooltip into editing mode and act as it already does in Actual.

Here are my changes; happy to create a PR if we're happy with this interaction:
master...gsumpster:gsumpster.reveal-notes-on-hover

I didn't modify the Tooltip component directly (scary file!), felt that introducing another event there would impact the rest of the application a little too much given its usage elsewhere.

@Kidglove57
Copy link

I love what you have done here! Thank you very much.
It is exactly what I envisaged when I first raised this a couple of years ago (I think on Slack). A great addition in my view.

Unfortunately, I have no skills to comment on the technicals so this is just a user perspective.

@j-f1
Copy link
Contributor

j-f1 commented Jan 27, 2023

@gsumpster That looks great! I think the only nitpick I have would be to rewrite lines 31–54 as a ternary but otherwise it looks great :)

@gsumpster
Copy link
Contributor

Sweet, thank you both for taking a look! I'll switch those lines over to a ternary and put up a PR!

@j-f1 j-f1 closed this as completed in #579 Jan 27, 2023
j-f1 added a commit that referenced this issue Jan 27, 2023
* add hover state to NotesButton

* switch NotesButton editability to a ternary

* fix new lines, adjust padding on textarea

* add workBreak to text styling

* Update packages/loot-design/src/components/NotesButton.js

Co-authored-by: Jed Fox <[email protected]>

* change wordBreak to overflowWrap

---------

Co-authored-by: Jed Fox <[email protected]>
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this issue Mar 7, 2024
…get#579)

* add hover state to NotesButton

* switch NotesButton editability to a ternary

* fix new lines, adjust padding on textarea

* add workBreak to text styling

* Update packages/loot-design/src/components/NotesButton.js

Co-authored-by: Jed Fox <[email protected]>

* change wordBreak to overflowWrap

---------

Co-authored-by: Jed Fox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants