🧪 improve setting e2e test stability (#3513)

actualbudget · Sep 27, 2024 · 666b787 · 666b787
1 parent 686ce5b
commit 666b787
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 3 deletions.
diff --git a/...s-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png b/...s-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png
diff --git a/...s-snapshots/Mobile-checks-that-settings-page-can-be-opened-5-chromium-linux.png b/...s-snapshots/Mobile-checks-that-settings-page-can-be-opened-5-chromium-linux.png
diff --git a/...s-snapshots/Mobile-checks-that-settings-page-can-be-opened-6-chromium-linux.png b/...s-snapshots/Mobile-checks-that-settings-page-can-be-opened-6-chromium-linux.png
diff --git a/...apshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png b/...apshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png
diff --git a/...ettings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png b/...ettings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png
diff --git a/packages/desktop-client/playwright.config.js b/packages/desktop-client/playwright.config.js
@@ -18,7 +18,7 @@ expect.extend({
     };
 
     // Check lightmode
-    await locator.evaluate(() => window.Actual.setTheme('light'));
+    await locator.evaluate(() => window.Actual.setTheme('auto'));
     const lightmode = await expect(locator).toHaveScreenshot(config);
 
     if (lightmode && !lightmode.pass) {
@@ -44,7 +44,7 @@ expect.extend({
     }
 
     // Switch back to lightmode
-    await locator.evaluate(() => window.Actual.setTheme('light'));
+    await locator.evaluate(() => window.Actual.setTheme('auto'));
     return {
       message: () => 'pass',
       pass: true,

diff --git a/packages/desktop-client/src/style/theme.tsx b/packages/desktop-client/src/style/theme.tsx
@@ -31,7 +31,7 @@ export const darkThemeOptions = Object.entries({
 }).map(([key, { name }]) => [key, name] as [DarkTheme, string]);
 
 export function useTheme() {
-  const [theme = 'light', setThemePref] = useGlobalPref('theme');
+  const [theme = 'auto', setThemePref] = useGlobalPref('theme');
   return [theme, setThemePref] as const;
 }
 

diff --git a/upcoming-release-notes/3513.md b/upcoming-release-notes/3513.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+e2e: improve settings test stability.