Patch lint & test

actualbudget · Jan 7, 2025 · 1ed938d · 1ed938d
1 parent 5269d52
commit 1ed938d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 17 deletions.
diff --git a/packages/desktop-client/globals.d.ts b/packages/desktop-client/globals.d.ts
@@ -10,5 +10,5 @@ declare module 'react' {
 }
 
 declare global {
-  var __resetWorld: () => void;
+  function __resetWorld(): void;
 }
diff --git a/packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx b/packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx
@@ -1,4 +1,4 @@
-import React, { useState, useEffect, type ComponentProps } from 'react';
+import React, { useState, useEffect } from 'react';
 
 import { render, screen, fireEvent } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
@@ -21,20 +21,20 @@ import {
   updateTransaction,
 } from 'loot-core/src/shared/transactions';
 import { integerToCurrency } from 'loot-core/src/shared/util';
+import {
+  type AccountEntity,
+  type CategoryEntity,
+  type CategoryGroupEntity,
+  type PayeeEntity,
+  type TransactionEntity,
+} from 'loot-core/types/models';
 
 import { AuthProvider } from '../../auth/AuthProvider';
 import { SelectedProviderWithItems } from '../../hooks/useSelected';
 import { SplitsExpandedProvider } from '../../hooks/useSplitsExpanded';
 import { ResponsiveProvider } from '../responsive/ResponsiveProvider';
 
 import { TransactionTable } from './TransactionsTable';
-import {
-  AccountEntity,
-  CategoryEntity,
-  CategoryGroupEntity,
-  PayeeEntity,
-  TransactionEntity,
-} from 'loot-core/types/models';
 
 vi.mock('loot-core/src/platform/client/fetch');
 vi.mock('../../hooks/useFeatureFlag', () => ({
@@ -135,6 +135,7 @@ function LiveTransactionTable(props: LiveTransactionTableProps) {
   useEffect(() => {
     if (transactions === props.transactions) return;
     props.onTransactionsChange?.(transactions);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [transactions]);
 
   const onSplit = (id: string) => {
@@ -1017,7 +1018,7 @@ describe('Transactions', () => {
         category: undefined,
         cleared: false,
         date: '2017-01-01',
-        error: null,
+        error: undefined,
         id: expect.any(String),
         is_parent: true,
         notes: 'Notes',
@@ -1035,6 +1036,7 @@ describe('Transactions', () => {
         is_child: true,
         parent_id: parentId,
         payee: 'alice-id',
+        reconciled: undefined,
         sort_order: -1,
         starting_balance_flag: null,
       },
@@ -1049,6 +1051,7 @@ describe('Transactions', () => {
         is_child: true,
         parent_id: parentId,
         payee: 'alice-id',
+        reconciled: undefined,
         sort_order: -2,
         starting_balance_flag: null,
       },

diff --git a/packages/loot-core/src/platform/client/fetch/index.d.ts b/packages/loot-core/src/platform/client/fetch/index.d.ts
@@ -1,5 +1,5 @@
-import type { CategoryGroupEntity } from '../../..//types/models';
 import type { Handlers } from '../../../types/handlers';
+import type { CategoryGroupEntity } from '../../../types/models';
 import type { ServerEvents } from '../../../types/server-events';
 
 export function init(socketName: string): Promise<unknown>;

diff --git a/packages/loot-core/src/server/accounts/rules.test.ts b/packages/loot-core/src/server/accounts/rules.test.ts
@@ -544,7 +544,6 @@ describe('Rule', () => {
       expect(
         fixedAmountRule.exec({ imported_payee: 'James', amount: 200 }),
       ).toMatchObject({
-        error: null,
         subtransactions: [{ amount: 100 }, { amount: 100 }],
       });
     });
@@ -571,7 +570,6 @@ describe('Rule', () => {
 
       expect(rule.exec({ imported_payee: 'James', amount: 200 })).toMatchObject(
         {
-          error: null,
           subtransactions: [{ amount: 100 }, { amount: 100 }],
         },
       );
@@ -597,7 +595,6 @@ describe('Rule', () => {
 
       expect(rule.exec({ imported_payee: 'James', amount: 200 })).toMatchObject(
         {
-          error: null,
           subtransactions: [{ amount: 100 }, { amount: 100 }],
         },
       );
@@ -632,7 +629,6 @@ describe('Rule', () => {
       expect(
         prioritizationRule.exec({ imported_payee: 'James', amount: 200 }),
       ).toMatchObject({
-        error: null,
         subtransactions: [{ amount: 100 }, { amount: 50 }, { amount: 50 }],
       });
     });
@@ -642,7 +638,6 @@ describe('Rule', () => {
       expect(
         prioritizationRule.exec({ imported_payee: 'James', amount: 50 }),
       ).toMatchObject({
-        error: null,
         subtransactions: [{ amount: 100 }, { amount: -25 }, { amount: -25 }],
       });
     });
@@ -674,7 +669,6 @@ describe('Rule', () => {
 
       expect(rule.exec({ imported_payee: 'James', amount: 150 })).toMatchObject(
         {
-          error: null,
           subtransactions: [{ amount: 100 }, { amount: 50 }, { amount: 0 }],
         },
       );