Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the link page for gocardless #311

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix the link page for gocardless #311

merged 2 commits into from
Feb 13, 2024

Conversation

twk3
Copy link
Contributor

@twk3 twk3 commented Feb 13, 2024

Ensures the redirect page is auto-closed after linking

After we dropped the nordigen endpoint in #293 this was no longer working.

(Closing the redirect page automatically will typically reveal the previous tab which is the waiting actual page, where you can then setup next steps)

Ensures the redirect page is auto-closed after linking
@trafico-bot trafico-bot bot added the 🚧 WIP label Feb 13, 2024
@twk3 twk3 changed the title [WIP]Fix the link page for gocardless Fix the link page for gocardless Feb 13, 2024
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I somehow missed this.

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review labels Feb 13, 2024
@twk3 twk3 merged commit cd4a2b6 into master Feb 13, 2024
8 checks passed
@twk3 twk3 deleted the twk3/fix-gocardless-link branch February 13, 2024 19:20
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Feb 13, 2024
MMichotte pushed a commit to MMichotte/actual-server that referenced this pull request Sep 9, 2024
* Fix the link page for gocardless

Ensures the redirect page is auto-closed after linking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants