Add workaround for non-unique transactionIds for Belfius bank #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
force-pushed
the
add-belfius-workaround
branch
from
3f54330 to
48d242e
Compare
nudded
force-pushed
the
add-belfius-workaround
branch
from
48d242e to
3db6bff
Compare
trafico-bot
bot
added
✅ Approved
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
…budget#283) Co-authored-by: Toon Willems <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Belfius bank has non-unique transaction ids causing data to not be synced.
This is documented in the gocardless api and there is an internalTransactionId field available which gocardless makes sure is unique.
This is documented here: https://nordigen.zendesk.com/hc/en-gb/articles/7427214507421-internalTransactionId-a-unique-transaction-ID-now-generated-by-GoCardless
Unfortunately this will be a breaking change for all Belfius users, but the alternative is having to manually reconcile the accounts from time to time.