Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "docker.io/" registry prefix to docker compose image #274

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Valloric
Copy link
Contributor

@Valloric Valloric commented Nov 4, 2023

Required by Podman Compose. Docker Compose should not care either way. The registry prefix is explicitly supported in the compose file spec

@joel-jeremy
Copy link

@MatissJanis do you think we should point the docker compose file to the GitHub container registry or should we use docker hub instead?

@joel-jeremy
Copy link

joel-jeremy commented Nov 10, 2023

@Valloric actual server images are also hosted on docker hub. Can we point the compose file there instead? Also, this needs to have a release notes to be merged. Please see https://github.com/actualbudget/docs#writing-good-release-notes on how to add one. :)

Required by Podman Compose. Docker Compose should not care either way. The registry prefix is explicitly supported in the [compose file spec](https://github.com/compose-spec/compose-spec/blob/master/spec.md#image)
@Valloric Valloric changed the title Add "ghcr.io/" registry prefix to docker compose image Add "docker.io/" registry prefix to docker compose image Nov 11, 2023
@Valloric
Copy link
Contributor Author

Valloric commented Nov 11, 2023

I changed the prefix to point to docker hub and added the release notes. Should be good to go now.

Some friendly advice from someone who spent 15+ years maintaining various OSS projects: the release notes process adds needless overhead and will cut the rate of PRs you get by a factor of 10. This process is largely automatable at the time of cutting a release. The non-automatable parts (categorization of bugfix/feature/whatever) is not worth the overhead.

Do with that advice as you wish. :)

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review labels Nov 21, 2023
@joel-jeremy
Copy link

Thank you! We'll keep that advice in mind. :)

@joel-jeremy joel-jeremy merged commit 87813b3 into actualbudget:master Nov 21, 2023
6 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Nov 21, 2023
MMichotte pushed a commit to MMichotte/actual-server that referenced this pull request Sep 9, 2024
…t#274)

Required by Podman Compose. Docker Compose should not care either way. The registry prefix is explicitly supported in the [compose file spec](https://github.com/compose-spec/compose-spec/blob/master/spec.md#image)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants