fixed p2p/bon remittance info, moved transaction date setter

actualbudget · Nov 29, 2024 · dc537e5 · dc537e5
1 parent 8a8f65d
commit dc537e5
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/app-gocardless/banks/hype_hyeeit22.js b/src/app-gocardless/banks/hype_hyeeit22.js
@@ -11,8 +11,6 @@ export default {
   accessValidForDays: 90,
 
   normalizeTransaction(transaction, _booked) {
-    // PREFER valueDate
-    transaction.bookingDate = transaction.valueDate ?? transaction.bookingDate;
 
     /** Online card payments - identified by "crd" transaction code
      *  always start with PAGAMENTO PRESSO + <payee name>
@@ -36,9 +34,10 @@ export default {
       // keep only {payment_info} portion of remittance info
       // NOTE: if {payee_name} contains dashes (unlikely / impossible?), this probably gets bugged!
       let infoIdx =
-        transaction.remittanceInformationUnstructured.indexOf(' - ') + 1;
+        transaction.remittanceInformationUnstructured.indexOf(' - ') + 3;
       transaction.remittanceInformationUnstructured =
-        transaction.remittanceInformationUnstructured.slice(infoIdx).trim();
+        infoIdx == -1 ? transaction.remittanceInformationUnstructured :
+          transaction.remittanceInformationUnstructured.slice(infoIdx).trim();
     }
     /**
      * CONVERT ESCAPED UNICODE TO CODEPOINTS
@@ -72,7 +71,7 @@ export default {
     return {
       ...transaction,
       payeeName: formatPayeeName(transaction),
-      date: transaction.bookingDate || transaction.valueDate,
+      date: transaction.valueDate || transaction.bookingDate,
     };
   },
 };