Return GoCardless rate limit information on error (#509)

actualbudget · Dec 6, 2024 · 645958b · 645958b
1 parent df958eb
commit 645958b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/app-gocardless/app-gocardless.js b/src/app-gocardless/app-gocardless.js
@@ -201,8 +201,19 @@ app.post(
         });
       }
     } catch (error) {
+      const headers = error.details?.response?.headers ?? {};
+
+      const rateLimitHeaders = Object.fromEntries(
+        Object.entries(headers).filter(([key]) =>
+          key.startsWith('http_x_ratelimit'),
+        ),
+      );
+
       const sendErrorResponse = (data) =>
-        res.send({ status: 'ok', data: { ...data, details: error.details } });
+        res.send({
+          status: 'ok',
+          data: { ...data, details: error.details, rateLimitHeaders },
+        });
 
       switch (true) {
         case error instanceof RequisitionNotLinked:

diff --git a/upcoming-release-notes/509.md b/upcoming-release-notes/509.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [matt-fidd]
+---
+
+Add more logging for GoCardless rate limit information