-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Relate measurements to truth in Examples #3838
refactor: Relate measurements to truth in Examples #3838
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
After discussions with @benjaminhuth we agreed that we would continue relying on maps for the mapping for now. I would like to pull out some changes from this PR which are not related to the feature change. Closing |
Relates our Examples measurements to truth hits and particles which makes the additional maps on the side unnecessary. This simplifies the modification of measurements collections as the truth relations do not need to be updated as well.
One potential problem is that we combine reconstruction and truth information in a single place and people might mix it up for reconstruction workflows without truth. However this is our Examples framework and not an experiment framework so the simplification outweighs the potential risk of misuse for experiments IMO.
Useful for #3836