Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gx2f): improve logging #3801

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@AJPfleger AJPfleger added the 🚧 WIP Work-in-progress label Oct 31, 2024
@AJPfleger AJPfleger added this to the next milestone Oct 31, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

📊: Physics performance monitoring for a297357

Full contents

physmon summary

AJPfleger and others added 2 commits October 31, 2024 14:21
…oject#3799)

As a step to make the gx2f easier to read, I pulled out the step, where we check out all trackstates and fill all variables of the gx2f-system.

Maybe we manage in the future to remove the template using a internal track-type and put this into a separate compile unit.
@AJPfleger AJPfleger removed the 🚧 WIP Work-in-progress label Oct 31, 2024
@AJPfleger AJPfleger marked this pull request as ready for review October 31, 2024 13:26
Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine!

Copy link

sonarcloud bot commented Oct 31, 2024

@kodiakhq kodiakhq bot merged commit 27bfc2d into acts-project:main Oct 31, 2024
42 checks passed
@AJPfleger AJPfleger deleted the gx2f-clean-logging branch October 31, 2024 15:36
@paulgessinger paulgessinger modified the milestones: next, v37.4.0, v37.3.0 Nov 8, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants