Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace fabs( and sqrtf( with std::abs and std::sqrt( #3787

Merged
merged 1 commit into from
Oct 27, 2024
Merged

refactor: replace fabs( and sqrtf( with std::abs and std::sqrt( #3787

merged 1 commit into from
Oct 27, 2024

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@AJPfleger AJPfleger added this to the v38.0.0 milestone Oct 27, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Vertexing Seeding Track Fitting labels Oct 27, 2024
@AJPfleger AJPfleger modified the milestones: v38.0.0, next Oct 27, 2024
@github-actions GitHub Actions
Copy link

📊: Physics performance monitoring for faa62be

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review October 27, 2024 13:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 27, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
48.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 4a3d715 into acts-project:main Oct 27, 2024
45 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [4a3d715]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 27, 2024
@AJPfleger AJPfleger deleted the f-funcs branch October 27, 2024 15:46
@paulgessinger paulgessinger modified the milestones: next, v37.4.0, v37.3.0 Nov 8, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@AJPfleger @Rosie-Hasan
refactor: replace fabs( and sqrtf( with std::abs and `std::sqrt…
3d4c469 
…(` (acts-project#3787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Seeding Track Fitting Vertexing
Projects
None yet
Milestone
v37.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AJPfleger @acts-project-service @paulgessinger