Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GeoSimplePolygonBrep to GeoModelToDetectorVolume #3713

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Matthewharri
Copy link
Contributor

This PR adds back in the conversion method for GeoSimplePolygonBrep to DetectorVolume. This somehow got removed during a refactoring.

Also included is a small bug fix that didn't propagate the volume transformation correctly for GeoShapeShift objects.

Tagging @junggjo9 @paulgessinger @noemina

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

📊: Physics performance monitoring for c78bacb

Full contents

physmon summary

@junggjo9
Copy link
Contributor

looks good to me

@paulgessinger paulgessinger added this to the next milestone Oct 10, 2024
Copy link

sonarcloud bot commented Oct 11, 2024

@kodiakhq kodiakhq bot merged commit 05c2168 into acts-project:main Oct 11, 2024
42 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 11, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
…ect#3713)

This PR adds back in the conversion method for `GeoSimplePolygonBrep` to `DetectorVolume`. This somehow got removed during a refactoring.

Also included is a small bug fix that didn't propagate the volume transformation correctly for `GeoShapeShift` objects.

Tagging @junggjo9 @paulgessinger @noemina
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants