-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add test for space point edm #3690
Merged
kodiakhq
merged 7 commits into
acts-project:main
from
CarloVarni:UnitTestForSpacePointIteration
Oct 4, 2024
Merged
feat: Add test for space point edm #3690
kodiakhq
merged 7 commits into
acts-project:main
from
CarloVarni:UnitTestForSpacePointIteration
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Event Data Model
labels
Oct 3, 2024
CarloVarni
force-pushed
the
UnitTestForSpacePointIteration
branch
from
October 4, 2024 08:11
4c90d20
to
aafb97d
Compare
AJPfleger
reviewed
Oct 4, 2024
AJPfleger
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Quality Gate passedIssues Measures |
acts-project-service
added
Breaks Athena build
This PR breaks the Athena build
Fails Athena tests
This PR causes a failure in the Athena tests
labels
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Event Data Model
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some unit test for the space point edm, with also checks on the types
Requires #3689 to compile (already merged)