-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Do not use geometry extent during seeding #3688
Conversation
don't mind sonarclound. The issues would require extensive changes. I'd like to decouple that fro this PR @paulgessinger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Examples/Algorithms/TrackFinding/src/SeedingAlgorithmHashing.cpp
Outdated
Show resolved
Hide resolved
I had to switch to |
Quality Gate passedIssues Measures |
In the seeding we only need the radius range of the space points (and only when the range is computed by the code and not provided by the user). As of now, when filling the grid we waste a lot of time to fill the
Acts::Extent
object (for all the possibleActs::BinningValue
even if we don't need them all).I have refactored the code so that we do not do this expensive operation. The user will have to do it by them selves or provide a validity search window via JO.
No changes expected from this PR