Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): Extent designated initialization #3680

Merged

Conversation

paulgessinger
Copy link
Member

This pull request introduces a new constructor for the ExtentEnvelope struct using a helper struct for designated initialization, and includes corresponding unit tests to ensure its functionality. The most important changes include the addition of the Arguments helper struct, the new constructor, and a new test case in the unit tests.

Enhancements to ExtentEnvelope struct:

  • Core/include/Acts/Geometry/Extent.hpp: Added a new helper struct Arguments for designated initializer construction and a corresponding constructor in ExtentEnvelope to utilize this struct.

Unit tests:

@paulgessinger paulgessinger added this to the next milestone Oct 2, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 2, 2024
@paulgessinger paulgessinger marked this pull request as draft October 2, 2024 08:32
@paulgessinger paulgessinger marked this pull request as ready for review October 2, 2024 08:40
Copy link

github-actions bot commented Oct 2, 2024

📊: Physics performance monitoring for fee8388

Full contents

physmon summary

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

Copy link

sonarcloud bot commented Oct 3, 2024

@kodiakhq kodiakhq bot merged commit b0fcfb4 into acts-project:main Oct 3, 2024
44 checks passed
@github-actions github-actions bot removed the automerge label Oct 3, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 3, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants