-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geo): Extent designated initialization #3680
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
paulgessinger:feat/extent-designated-init
Oct 3, 2024
Merged
feat(geo): Extent designated initialization #3680
kodiakhq
merged 3 commits into
acts-project:main
from
paulgessinger:feat/extent-designated-init
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
Quality Gate passedIssues Measures |
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new constructor for the
ExtentEnvelope
struct using a helper struct for designated initialization, and includes corresponding unit tests to ensure its functionality. The most important changes include the addition of theArguments
helper struct, the new constructor, and a new test case in the unit tests.Enhancements to
ExtentEnvelope
struct:Core/include/Acts/Geometry/Extent.hpp
: Added a new helper structArguments
for designated initializer construction and a corresponding constructor inExtentEnvelope
to utilize this struct.Unit tests:
Tests/UnitTests/Core/Geometry/ExtentTests.cpp
: Added a new test caseDesignatedInitializers
to verify the functionality of the new designated initializer constructor inExtentEnvelope
.