Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modernise type traits #3655

Merged
merged 5 commits into from
Oct 1, 2024
Merged

refactor: modernise type traits #3655

merged 5 commits into from
Oct 1, 2024

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@AJPfleger AJPfleger added this to the next milestone Sep 27, 2024
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where these types are used in assertions, I would suggest using equivalent concepts and (if practical) requires-clauses.

Core/include/Acts/Surfaces/ConvexPolygonBounds.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/Propagator.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/Propagator.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/Propagator.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/Propagator.ipp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 27, 2024

📊: Physics performance monitoring for a61145d

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review September 27, 2024 14:49
@AJPfleger
Copy link
Contributor Author

@stephenswat thanks for the comments, I already started with some of the suggestions beofre, but hadn't finished yet. Should be ready now :)

@AJPfleger AJPfleger modified the milestones: next, v37.0.0 Oct 1, 2024
Copy link

sonarcloud bot commented Oct 1, 2024

@kodiakhq kodiakhq bot merged commit aa53675 into acts-project:main Oct 1, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 1, 2024
@AJPfleger AJPfleger deleted the type branch October 1, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants