Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump core count in GitLab CI to 8 #3651

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added this to the v37.0.0 milestone Sep 26, 2024
AJPfleger
AJPfleger previously approved these changes Sep 26, 2024
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now my tests can fail twice as fast ヾ(@^▽^@)ノ

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to use $(nproc) here?

@paulgessinger
Copy link
Member Author

@stephenswat We'll likely run out of memory at nproc (=8) at this time.
@AJPfleger I'd like to play around with this a bit before merging.

@AJPfleger
Copy link
Contributor

AJPfleger commented Sep 26, 2024

I think the problem with $(nproc) is that we are limited by memory. We set it to -j2 before to not crash the build.

edit @paulgessinger was a second faster

Copy link

github-actions bot commented Sep 26, 2024

📊: Physics performance monitoring for a071a9c

Full contents

physmon summary

@paulgessinger
Copy link
Member Author

Memory consumption seems to have peaked below 50%, let's just try eight cores.

AJPfleger
AJPfleger previously approved these changes Sep 26, 2024
@paulgessinger paulgessinger changed the title ci: Bump core count in GitLab CI to 4 ci: Bump core count in GitLab CI to 8 Sep 26, 2024
@paulgessinger
Copy link
Member Author

I checked one job using Grafana and it seems like we're fine on memory even at 8 cores.

image image

This reverts commit c312e87.
@kodiakhq kodiakhq bot merged commit 008f1b3 into acts-project:main Sep 26, 2024
41 checks passed
Copy link

sonarcloud bot commented Sep 26, 2024

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 26, 2024
@paulgessinger paulgessinger deleted the gitlab-j branch September 27, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants