-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove MPL library #3642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
6b898a6
to
e448527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Some of this are remnants from when I excised boost::mpl
and reimplemented some stuff in C++14.
Happy to see this go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, I could make sense to fix the marked sonarcloud issues. The others, I am fine with ignoring in this PR.
I'll take care of the SonarCloud issues. 👍 |
b615de1
b615de1
to
9ffe365
Compare
Done; thanks for the suggestion. |
This commit removes the mostly unused MPL library. The few cases in which it was being used could be easily refactored into uses of fold expressions, which should allow better error messages.
That looks good, @AJPfleger - can you check again if you're happy! I like cleanup PRs very very much. |
Quality Gate passedIssues Measures |
This commit removes the mostly unused MPL library. The few cases in which it was being used could be easily refactored into uses of fold expressions, which should allow better error messages.