Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove MPL library #3642

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

stephenswat
Copy link
Member

This commit removes the mostly unused MPL library. The few cases in which it was being used could be easily refactored into uses of fold expressions, which should allow better error messages.

@github-actions github-actions bot added the Component - Core Affects the Core module label Sep 24, 2024
andiwand
andiwand previously approved these changes Sep 24, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link

github-actions bot commented Sep 24, 2024

📊: Physics performance monitoring for 0c23731

Full contents

physmon summary

andiwand
andiwand previously approved these changes Sep 24, 2024
paulgessinger
paulgessinger previously approved these changes Sep 24, 2024
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Some of this are remnants from when I excised boost::mpl and reimplemented some stuff in C++14.

Happy to see this go!

@paulgessinger paulgessinger added this to the v37.0.0 milestone Sep 24, 2024
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, I could make sense to fix the marked sonarcloud issues. The others, I am fine with ignoring in this PR.

Core/include/Acts/Utilities/detail/Extendable.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/ActorList.hpp Outdated Show resolved Hide resolved
@stephenswat
Copy link
Member Author

I'll take care of the SonarCloud issues. 👍

@stephenswat stephenswat force-pushed the refactor/remove_mpl branch 2 times, most recently from b615de1 to 9ffe365 Compare September 25, 2024 08:21
@stephenswat
Copy link
Member Author

Done; thanks for the suggestion.

stephenswat and others added 2 commits September 25, 2024 10:23
This commit removes the mostly unused MPL library. The few cases in
which it was being used could be easily refactored into uses of fold
expressions, which should allow better error messages.
@asalzburger
Copy link
Contributor

That looks good, @AJPfleger - can you check again if you're happy! I like cleanup PRs very very much.

@andiwand andiwand modified the milestones: v37.0.0, next Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

@kodiakhq kodiakhq bot merged commit cd7810d into acts-project:main Sep 25, 2024
44 checks passed
@paulgessinger paulgessinger removed this from the next milestone Oct 4, 2024
@paulgessinger paulgessinger added this to the v37.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants