Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use std::ranges::sort and reverse #3596

Merged
merged 38 commits into from
Sep 12, 2024
Merged

refactor: use std::ranges::sort and reverse #3596

merged 38 commits into from
Sep 12, 2024

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@AJPfleger AJPfleger added this to the next milestone Sep 5, 2024
stephenswat
stephenswat approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless, happy to approve this if the CI likes it.

Core/include/Acts/Clusterization/Clusterization.ipp Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
47.7% Coverage on New Code
4.3% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit d250bbf into acts-project:main Sep 12, 2024
42 checks passed
@AJPfleger AJPfleger deleted the ranges branch September 12, 2024 15:12
@acts-project-service
Copy link
Collaborator

acts-project-service commented Sep 12, 2024 •
edited
Loading

🔴 Athena integration test results [d250bbf]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 12, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenswat stephenswat stephenswat approved these changes

@benjaminhuth benjaminhuth Awaiting requested review from benjaminhuth

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Clustering Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Event Data Model Seeding Track Finding Track Fitting Vertexing
Projects
None yet
Milestone
v37.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AJPfleger @acts-project-service @stephenswat @benjaminhuth @paulgessinger