-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detray geometry/material conversion in examples #3579
feat: detray geometry/material conversion in examples #3579
Conversation
ff2c842
to
fcda407
Compare
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Show resolved
Hide resolved
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Outdated
Show resolved
Hide resolved
Added some more tests to make sonar cloud happy. |
@niermann999 - can you help me on the CI/UnitTest failure ... what would it be to have a mismatching |
Odd, indeed. Did you add empty material payloads for surfaces that don't have material per chance? |
The funny thing is: ./ActsUnitTestDetrayConverter
Running 1 test case...
WARNING: No entries in volume finder
*** No errors detected Locally it runs. |
Ah, I see, it's an |
I've added a dedicated |
@niermann999 - this is now ready to review, also - it looks like the loading of binned material and homogeneous material works with two readers ... great ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy that the homogeneous material conversion seems to work!
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion points solved
Quality Gate passedIssues Measures |
This PR builds upon #3546 (and others) and introduces the first tests to run detray geometry conversion in memory and then write out json files.
It also introduces a
DetrayPropagator
which implements theActsExamples::PropagatorInterface
and hence can be run with theActsExamples::PropagationAlgorithm
, see below:NOTE
The
propagate()
method ofdetray
is currently not const, hence the propagator needs to bemutable
for the moment, a fix for detray is in preparation.Currently possible:
@niermann999 @stephenswat can you please have a look at the implementation of the
DetrayStore
and theDetrayHotStore
in particular, the idea here is to not exposevecmem
specifics to the python bindings.For handling
Traccc/Detray
in theActsFramework
I propose the following:Python/src/Detray.cpp
binding codeActsExamples/Algorithms/Framework/Traccc
with its associated bindings.@EleniXoch FYI