Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detray geometry/material conversion in examples #3579

Merged
merged 19 commits into from
Sep 4, 2024

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Aug 30, 2024

This PR builds upon #3546 (and others) and introduces the first tests to run detray geometry conversion in memory and then write out json files.

It also introduces a DetrayPropagator which implements the ActsExamples::PropagatorInterface and hence can be run with the ActsExamples::PropagationAlgorithm, see below:

Screenshot 2024-09-02 at 11 08 54

NOTE
The propagate() method of detray is currently not const, hence the propagator needs to be mutable for the moment, a fix for detray is in preparation.

Currently possible:

  • geometry writing (validated)
  • material writing (validated) - will be part of a followup PR

@niermann999 @stephenswat can you please have a look at the implementation of the DetrayStore and the DetrayHotStore in particular, the idea here is to not expose vecmem specifics to the python bindings.

For handling Traccc/Detray in the ActsFramework I propose the following:

  • pure geometry conversion and e.g. writing to files can be done with the Python/src/Detray.cpp binding code
  • all the rest goes into ActsExamples/Algorithms/Framework/Traccc with its associated bindings.

@EleniXoch FYI

@asalzburger asalzburger added this to the next milestone Aug 30, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

📊: Physics performance monitoring for 8133d68

Full contents

physmon summary

@github-actions github-actions bot added the Component - Core Affects the Core module label Sep 2, 2024
@asalzburger
Copy link
Contributor Author

Added some more tests to make sonar cloud happy.

@asalzburger
Copy link
Contributor Author

@niermann999 - can you help me on the CI/UnitTest failure ... what would it be to have a mismatching mat_id ?

@niermann999
Copy link
Contributor

@niermann999 - can you help me on the CI/UnitTest failure ... what would it be to have a mismatching mat_id ?

Odd, indeed. Did you add empty material payloads for surfaces that don't have material per chance?

@asalzburger
Copy link
Contributor Author

The funny thing is:

 ./ActsUnitTestDetrayConverter
Running 1 test case...
WARNING: No entries in volume finder


*** No errors detected

Locally it runs.

@asalzburger
Copy link
Contributor Author

The funny thing is:

 ./ActsUnitTestDetrayConverter
Running 1 test case...
WARNING: No entries in volume finder


*** No errors detected

Locally it runs.

Ah, I see, it's an assert

@asalzburger
Copy link
Contributor Author

I've added a dedicated homogeneous_material_reader and avoided doing the conversion of homogeneous material in fake 1-1 bin material.

@asalzburger
Copy link
Contributor Author

@niermann999 - this is now ready to review, also - it looks like the loading of binned material and homogeneous material works with two readers ... great !

Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy that the homogeneous material conversion seems to work!

Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion points solved

Copy link

sonarcloud bot commented Sep 4, 2024

@kodiakhq kodiakhq bot merged commit 9e1d9ef into acts-project:main Sep 4, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Sep 4, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants